xiaoxiang781216 commented on code in PR #6057:
URL: https://github.com/apache/incubator-nuttx/pull/6057#discussion_r850688637
##########
include/net/if.h:
##########
@@ -215,17 +229,18 @@ struct ifreq
int16_t ifr_ifindex; /* Interface index */
union
{
- struct sockaddr ifru_addr; /* IP Address */
- struct sockaddr ifru_dstaddr; /* P-to-P Address */
- struct sockaddr ifru_broadaddr; /* Broadcast address */
- struct sockaddr ifru_netmask; /* Netmask */
- struct sockaddr ifru_hwaddr; /* MAC address */
- int ifru_count; /* Number of devices */
- int ifru_mtu; /* MTU size */
- uint8_t ifru_flags; /* Interface flags */
- struct mii_ioctl_notify_s ifru_mii_notify; /* PHY event
notification */
- struct mii_ioctl_data_s ifru_mii_data; /* MII request data */
- struct can_ioctl_data_s ifru_can_data; /* CAN bitrate request
data */
+ struct sockaddr ifru_addr; /* IP Address */
+ struct sockaddr ifru_dstaddr; /* P-to-P Address */
+ struct sockaddr ifru_broadaddr; /* Broadcast address
*/
+ struct sockaddr ifru_netmask; /* Netmask */
+ struct sockaddr ifru_hwaddr; /* MAC address */
+ int ifru_count; /* Number of devices
*/
+ int ifru_mtu; /* MTU size */
+ uint8_t ifru_flags; /* Interface flags */
+ struct mii_ioctl_notify_s ifru_mii_notify; /* PHY event
notification */
+ struct mii_ioctl_data_s ifru_mii_data; /* MII request data
*/
+ struct can_ioctl_bitrate_s ifru_can_data; /* CAN bitrate request
data */
Review Comment:
ifru_can_data->ifru_can_bitrate?
##########
include/net/if.h:
##########
@@ -215,17 +229,18 @@ struct ifreq
int16_t ifr_ifindex; /* Interface index */
union
{
- struct sockaddr ifru_addr; /* IP Address */
- struct sockaddr ifru_dstaddr; /* P-to-P Address */
- struct sockaddr ifru_broadaddr; /* Broadcast address */
- struct sockaddr ifru_netmask; /* Netmask */
- struct sockaddr ifru_hwaddr; /* MAC address */
- int ifru_count; /* Number of devices */
- int ifru_mtu; /* MTU size */
- uint8_t ifru_flags; /* Interface flags */
- struct mii_ioctl_notify_s ifru_mii_notify; /* PHY event
notification */
- struct mii_ioctl_data_s ifru_mii_data; /* MII request data */
- struct can_ioctl_data_s ifru_can_data; /* CAN bitrate request
data */
+ struct sockaddr ifru_addr; /* IP Address */
+ struct sockaddr ifru_dstaddr; /* P-to-P Address */
+ struct sockaddr ifru_broadaddr; /* Broadcast address
*/
+ struct sockaddr ifru_netmask; /* Netmask */
+ struct sockaddr ifru_hwaddr; /* MAC address */
+ int ifru_count; /* Number of devices
*/
+ int ifru_mtu; /* MTU size */
+ uint8_t ifru_flags; /* Interface flags */
+ struct mii_ioctl_notify_s ifru_mii_notify; /* PHY event
notification */
+ struct mii_ioctl_data_s ifru_mii_data; /* MII request data
*/
Review Comment:
remove two space before /*?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
