davids5 commented on code in PR #6725:
URL: https://github.com/apache/incubator-nuttx/pull/6725#discussion_r931995745


##########
include/nuttx/spinlock.h:
##########
@@ -35,6 +35,7 @@
 #ifndef CONFIG_SPINLOCK
 typedef struct
 {
+  uint8_t unused;    /* NULL structure may caused build issue. */

Review Comment:
   Why does this even exists? When CONFIG_SPINLOCK not defied then why is it 
needed? Is the proper fix to ifdef the offending code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to