xiaoxiang781216 commented on code in PR #6725:
URL: https://github.com/apache/incubator-nuttx/pull/6725#discussion_r932020193
##########
include/nuttx/spinlock.h:
##########
@@ -35,6 +35,7 @@
#ifndef CONFIG_SPINLOCK
typedef struct
{
+ uint8_t unused; /* NULL structure may caused build issue. */
Review Comment:
This would require many places add #ifdef/#endif:
```
ifdef CONFIG_SPINLOCK
struct spinlock_s xxx;
#endif
```
another approach is define the spinlock by macro like:
https://github.com/apache/incubator-nuttx/blob/master/include/nuttx/power/pm.h#L90-L91
https://github.com/apache/incubator-nuttx/blob/master/include/nuttx/power/pm.h#L802
what do you think? @masayuki2009 and @davids5 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
