xiaoxiang781216 commented on code in PR #7981: URL: https://github.com/apache/nuttx/pull/7981#discussion_r1059075666
########## include/nuttx/note/notelog_driver.h: ########## @@ -0,0 +1,62 @@ +/**************************************************************************** + * include/nuttx/note/notelog_driver.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __INCLUDE_NUTTX_NOTE_NOTELOG_DRIVER_H +#define __INCLUDE_NUTTX_NOTE_NOTELOG_DRIVER_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <stddef.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + + +/**************************************************************************** + * Public Types + ****************************************************************************/ + +#if defined(__cplusplus) +extern "C" +{ +#endif + +/**************************************************************************** + * Public Function Prototypes + ****************************************************************************/ + +/**************************************************************************** + * Public Data + ****************************************************************************/ + +extern struct note_driver_s g_notelog_driver; Review Comment: add #ifdef/#endif ########## drivers/note/notelog_driver.c: ########## @@ -319,36 +318,6 @@ void sched_note_spinlock(FAR struct tcb_s *tcb, } #endif -#ifdef CONFIG_SCHED_INSTRUMENTATION_SYSCALL -void sched_note_syscall_enter(int nr, int argc, ...) -{ - char buf[128]; - FAR char *p = buf; - va_list ap; - - va_start(ap, argc); - while (argc-- > 0) - { - if (argc) - { - p += sprintf(p, "%#"PRIxPTR", ", va_arg(ap, uintptr_t)); - } - else - { - p += sprintf(p, "%#"PRIxPTR, va_arg(ap, uintptr_t)); - } - } - - va_end(ap); - syslog(LOG_INFO, "%s@%d ENTER %s\n", g_funcnames[nr], nr, buf); Review Comment: let's skip the log for syslog/getpid to void the infinite recursive loop instead removing all syscall log? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
