Gary-Hobson commented on code in PR #7981:
URL: https://github.com/apache/nuttx/pull/7981#discussion_r1059320366
##########
drivers/note/notelog_driver.c:
##########
@@ -319,36 +318,6 @@ void sched_note_spinlock(FAR struct tcb_s *tcb,
}
#endif
-#ifdef CONFIG_SCHED_INSTRUMENTATION_SYSCALL
-void sched_note_syscall_enter(int nr, int argc, ...)
-{
- char buf[128];
- FAR char *p = buf;
- va_list ap;
-
- va_start(ap, argc);
- while (argc-- > 0)
- {
- if (argc)
- {
- p += sprintf(p, "%#"PRIxPTR", ", va_arg(ap, uintptr_t));
- }
- else
- {
- p += sprintf(p, "%#"PRIxPTR, va_arg(ap, uintptr_t));
- }
- }
-
- va_end(ap);
- syslog(LOG_INFO, "%s@%d ENTER %s\n", g_funcnames[nr], nr, buf);
Review Comment:
This is not a good idea, it will cause a lot of unnecessary changes, and
notelog is not a good way to trace
We should try to use noteram instead of notelog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
