jturnsek commented on code in PR #8728:
URL: https://github.com/apache/nuttx/pull/8728#discussion_r1125967267
##########
net/local/local_sockif.c:
##########
@@ -833,7 +833,7 @@ static int local_close(FAR struct socket *psock)
static int local_ioctl(FAR struct socket *psock, int cmd, unsigned long arg)
{
FAR struct local_conn_s *conn;
- int ret = OK;
+ int ret = -ENOTTY;
Review Comment:
> it's already be done at line 878.
I do not think it is the same. If you see the first case FIONBIO, I think
there is a way to go through this case without setting ret variable, thus ret
was set to OK at init and this is not the proper return value in that case. Am
I wrong here?
In nuttx-apps repo, I have submitted a PR for nng with Pub/Sub example and
you can test it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
