[GitHub] [nuttx] jturnsek commented on a diff in pull request #8728: Hotfix of local_ioctl for fcntl with O_NONBLOCK to work

Mon, 06 Mar 2023 11:27:33 -0800 


jturnsek commented on code in PR #8728:
URL: https://github.com/apache/nuttx/pull/8728#discussion_r1126929167


##########
net/local/local_sockif.c:
##########
@@ -833,7 +833,7 @@ static int local_close(FAR struct socket *psock)
 static int local_ioctl(FAR struct socket *psock, int cmd, unsigned long arg)
 {
   FAR struct local_conn_s *conn;
-  int ret = OK;
+  int ret = -ENOTTY;

Review Comment:
   > Oh, in most case, lc_infile/lc_outfile shouldn't NULL. In your case, is 
both NULL?
   
   Yes, Both are NULL. Here is my callstack:
   
![image](https://user-images.githubusercontent.com/2845923/223210808-69ee4d9f-603a-4aba-9b1a-7e4b7f9635d2.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to