Gary-Hobson commented on code in PR #11153:
URL: https://github.com/apache/nuttx/pull/11153#discussion_r1387712727
##########
drivers/note/note_driver.c:
##########
@@ -580,8 +558,7 @@ static void note_record_taskname(pid_t pid, FAR const char
*name)
ti = (FAR struct note_taskname_info_s *)
&g_note_taskname.buffer[g_note_taskname.head];
ti->size = skiplen;
- ti->pid[0] = 0xff;
- ti->pid[1] = 0xff;
+ ti->pid = 0xffff;
Review Comment:
Yes, it needs to be modified here
But I think it would be better to change it to -1, which indicates an
illegal pid
##########
drivers/note/note_driver.c:
##########
@@ -592,8 +569,7 @@ static void note_record_taskname(pid_t pid, FAR const char
*name)
ti = (FAR struct note_taskname_info_s *)
&g_note_taskname.buffer[g_note_taskname.head];
ti->size = tilen;
- ti->pid[0] = pid & 0xff;
- ti->pid[1] = (pid >> 8) & 0xff;
+ ti->pid = pid;
Review Comment:
Here is the normal assignment of value to pid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
