xiaoxiang781216 commented on code in PR #11153:
URL: https://github.com/apache/nuttx/pull/11153#discussion_r1390607108
##########
drivers/note/note_driver.c:
##########
@@ -1065,10 +1041,9 @@ void sched_note_premption(FAR struct tcb_s *tcb, bool
locked)
if (!formatted)
{
formatted = true;
+ note.npr_count = tcb->lockcount;
Review Comment:
move after line 1045
##########
drivers/note/note_driver.c:
##########
@@ -1489,9 +1459,8 @@ void sched_note_vprintf_ip(uint32_t tag, uintptr_t ip,
length = sizeof(data);
}
+ note->nst_ip = ip;
Review Comment:
move after line 1463
##########
drivers/note/note_driver.c:
##########
@@ -1383,8 +1353,8 @@ void sched_note_string_ip(uint32_t tag, uintptr_t ip, FAR
const char *buf)
length = sizeof(data);
}
+ note->nst_ip = ip;
Review Comment:
move after line 1357
##########
drivers/note/note_driver.c:
##########
@@ -1434,8 +1404,8 @@ void sched_note_event_ip(uint32_t tag, uintptr_t ip,
uint8_t event,
length = sizeof(data);
}
+ note->nbi_ip = ip;
Review Comment:
move after line 1407
##########
drivers/note/note_driver.c:
##########
@@ -1708,8 +1677,8 @@ void sched_note_vbprintf_ip(uint32_t tag, uintptr_t ip,
length = SIZEOF_NOTE_BINARY(next);
+ note->nbi_ip = ip;
Review Comment:
move after line 1712
##########
drivers/note/noteram_driver.c:
##########
@@ -668,16 +650,15 @@ static int noteram_dump_header(FAR struct lib_outstream_s
*s,
uint32_t sec;
int ret;
- noteram_dump_unflatten(&nsec, note->nc_systime_nsec, sizeof(nsec));
- noteram_dump_unflatten(&sec, note->nc_systime_sec, sizeof(sec));
+ nsec = note->nc_systime_nsec;
Review Comment:
merge to line 648-650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
