Ji-Xinyou commented on code in PR #2329:
URL:
https://github.com/apache/incubator-opendal/pull/2329#discussion_r1206473557
##########
bindings/c/src/types.rs:
##########
@@ -178,3 +180,63 @@ impl opendal_metadata {
}
}
}
+
+/// [`opendal_operator_options`] represents a series of string type key-value
pairs, it may be used for initialization
+#[repr(transparent)]
+pub struct opendal_operator_options {
+ pub inner: *mut HashMap<String, String>,
Review Comment:
> I'm bit confused about that. It's ok to use `HashMap` in
`opendal_operator_options`. But we expose a public struct call
`opendal_operator_options` in C with its own API. Why we need to expose
`HashMap_String__String` too?
Inside the opendal_operator_options, it is a pointer to a HashMap<String,
String>.
When we compile the opendal library, we actually compile it along with the
Ruststd (since it is a Rust code).
Therefore, the compiled library will contains a type called
`HashMap_String__String`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
