Ji-Xinyou commented on code in PR #2329:
URL:
https://github.com/apache/incubator-opendal/pull/2329#discussion_r1206474946
##########
bindings/c/src/types.rs:
##########
@@ -178,3 +180,63 @@ impl opendal_metadata {
}
}
}
+
+/// [`opendal_operator_options`] represents a series of string type key-value
pairs, it may be used for initialization
+#[repr(transparent)]
+pub struct opendal_operator_options {
+ pub inner: *mut HashMap<String, String>,
Review Comment:
> > I access the keys and values in the `opendal_operator_new()`, so a
pub(crate) will make it easier.
>
> Oh, I got it. It's better to add a API `into_inner` (in Rust only) for
`opendal_operator_options` instead access inner directly.
Maybe not `into_inner`, since it will consume the HashMap. We could just
have a `as_ref`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
