Xuanwo commented on code in PR #5195:
URL: https://github.com/apache/opendal/pull/5195#discussion_r1805966449
##########
bindings/cpp/Cargo.toml:
##########
@@ -34,6 +34,8 @@ crate-type = ["staticlib"]
anyhow = "1.0"
chrono = "0.4"
cxx = "1.0"
+# cxx-async v0.1.1 in crates.io has build problems, so we use git repo directly
+cxx-async = { git = "https://github.com/pcwalton/cxx-async";, rev =
"961dd106b8eb2a86991728e1a18948e597426c1a", optional = true }
Review Comment:
This may prevent us from merging this PR. OpenDAL does not permit
dependencies on a git version crate, as this could disrupt our release process.
I'm trying to contact with @pcwalton at
https://github.com/pcwalton/cxx-async/issues/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
