Xuanwo commented on PR #5195: URL: https://github.com/apache/opendal/pull/5195#issuecomment-2481891150
Thank you @silver-ymz for the review. Let's move! > Great! > > Cmake with a version greater than 3.24 may issue a warning. > > ``` > CMake Warning (dev) at /usr/share/cmake-3.25/Modules/FetchContent.cmake:1279 (message): > The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is > not set. The policy's OLD behavior will be used. When using a URL > download, the timestamps of extracted files should preferably be that of > the time of extraction, otherwise code that depends on the extracted > contents might not be rebuilt if the URL changes. The OLD behavior > preserves the timestamps from the archive instead, but this is usually not > what you want. Update your project to the NEW behavior or specify the > DOWNLOAD_EXTRACT_TIMESTAMP option with a value of true to avoid this > robustness issue. > Call Stack (most recent call first): > CMakeLists.txt:121 (FetchContent_Declare) > ``` > > We can fix it in another PR, for example by adding the following to `CmakeLists.txt` > > ```cmake > if (POLICY CMP0135) > cmake_policy(SET CMP0135 NEW) > endif () > ``` Thank you for your review! Tracked at https://github.com/apache/opendal/issues/5337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
