jorgehermo9 commented on code in PR #6090:
URL: https://github.com/apache/opendal/pull/6090#discussion_r2061273874
##########
core/src/services/yandex_disk/backend.rs:
##########
@@ -229,14 +227,8 @@ impl Access for YandexDiskBackend {
}
async fn read(&self, path: &str, args: OpRead) -> Result<(RpRead,
Self::Reader)> {
- // TODO: move this out of reader.
Review Comment:
Is it okay to remove this TODO? Is this addressed now? I see the
`get_download_url` and `download(download_url)` pattern in few `backend.rs` and
it think it is the recommended approach, right? Or should we move both
`get_download_url` and `download(download_url)` into a new `read` function
inside `core.rs` so the backend is abstracted from this two-step flow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
