jorgehermo9 commented on code in PR #6090:
URL: https://github.com/apache/opendal/pull/6090#discussion_r2061281070
##########
core/src/services/yandex_disk/backend.rs:
##########
@@ -229,14 +227,8 @@ impl Access for YandexDiskBackend {
}
async fn read(&self, path: &str, args: OpRead) -> Result<(RpRead,
Self::Reader)> {
- // TODO: move this out of reader.
Review Comment:
Oh, I see that `b2` service encapsulates both `download_url` and `download`
in core
https://github.com/apache/opendal/blob/05dde6a22201b7e20f96260db9192c23d213001c/core/src/services/b2/core.rs#L241
Should we do the same here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
