tisonkun commented on code in PR #634:
URL: https://github.com/apache/opendal-reqsign/pull/634#discussion_r2377739671
##########
services/azure-storage/src/provide_credential/client_certificate.rs:
##########
@@ -33,8 +33,8 @@ use crate::credential::Credential;
/// Generate a unique JWT ID using timestamp and a pseudo-random component
fn generate_jti(now: u64) -> String {
// Use timestamp in nanoseconds + a hash of the timestamp for uniqueness
- let nano_time = std::time::SystemTime::now()
- .duration_since(std::time::UNIX_EPOCH)
+ let nano_time = SystemTime::now()
+ .duration_since(UNIX_EPOCH)
Review Comment:
I get your point. Although, I'd keep the current code as is and leave
investigating such a refactor later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]