BurntSushi commented on code in PR #634:
URL: https://github.com/apache/opendal-reqsign/pull/634#discussion_r2378523556
##########
core/src/time.rs:
##########
@@ -89,12 +47,12 @@ const HTTP_DATE: &[Item<'static>] = &[
/// - Timezone is fixed to GMT.
/// - Day must be 2 digit.
pub fn format_http_date(t: DateTime) -> String {
- t.format_with_items(HTTP_DATE.iter()).to_string()
+ t.strftime("%a, %d %b %Y %T GMT").to_string()
Review Comment:
Possibly perf. And I think it makes the code clearer to use a dedicated
printer. But that's your call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
