tisonkun commented on code in PR #634:
URL: https://github.com/apache/opendal-reqsign/pull/634#discussion_r2370741703
##########
services/aws-v4/src/provide_credential/sso.rs:
##########
@@ -218,11 +218,11 @@ impl SSOCredentialProvider {
})?;
// Check if token is expired
- let expires_at: DateTime<Utc> =
token.expires_at.parse().map_err(|e| {
+ let expires_at =
token.expires_at.parse::<DateTime>().map_err(|e| {
Review Comment:
jiff has a civil DateTime, so I'm afraid that this type name may cause
ambiguity.
Perhaps (in the long term?) we'd encapsulate jiff types and methods behind
reqsign-core so that concrete services won't depend on jiff directly, and thus
there is no ambiguity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
