Xuanwo commented on code in PR #6508:
URL: https://github.com/apache/opendal/pull/6508#discussion_r2476522367
##########
core/src/services/s3/core.rs:
##########
@@ -275,6 +275,7 @@ impl S3Core {
.for_each(|b| crc = crc32c::crc32c_append(crc, &b));
Some(BASE64_STANDARD.encode(crc.to_be_bytes()))
}
+ Some(ChecksumAlgorithm::Md5) =>
Some(format_content_md5(body.to_bytes().as_ref())),
Review Comment:
Do we have a better way to handle this, like calculating in a stream instead
of calling `body.to_bytes()` first? Our users might send data up to 5GiB in a
single request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
