waynexia commented on code in PR #6508:
URL: https://github.com/apache/opendal/pull/6508#discussion_r2476797964
##########
core/src/services/s3/core.rs:
##########
@@ -275,6 +275,7 @@ impl S3Core {
.for_each(|b| crc = crc32c::crc32c_append(crc, &b));
Some(BASE64_STANDARD.encode(crc.to_be_bytes()))
}
+ Some(ChecksumAlgorithm::Md5) =>
Some(format_content_md5(body.to_bytes().as_ref())),
Review Comment:
:+1: made a non-copy version `format_content_md5_iter` that works on iterator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
