svn commit: r1924853 - in /pdfbox/branches/3.0: examples/src/test/java/org/apache/pdfbox/examples/pdfa/ pdfbox/src/test/java/org/apache/pdfbox/multipdf/ xmpbox/src/test/java/org/apache/xmpbox/type/

Sat, 05 Apr 2025 22:04:43 -0700 

Author: tilman
Date: Sun Apr  6 05:04:35 2025
New Revision: 1924853

URL: http://svn.apache.org/viewvc?rev=1924853&view=rev
Log:
PDFBOX-5660: Sonar fix

Modified:
    
pdfbox/branches/3.0/examples/src/test/java/org/apache/pdfbox/examples/pdfa/MergePDFATest.java
    
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAcroFormsTest.java
    
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAnnotationsTest.java
    
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/OverlayTest.java
    
pdfbox/branches/3.0/xmpbox/src/test/java/org/apache/xmpbox/type/TestDerivedType.java

Modified: 
pdfbox/branches/3.0/examples/src/test/java/org/apache/pdfbox/examples/pdfa/MergePDFATest.java
URL: 
http://svn.apache.org/viewvc/pdfbox/branches/3.0/examples/src/test/java/org/apache/pdfbox/examples/pdfa/MergePDFATest.java?rev=1924853&r1=1924852&r2=1924853&view=diff
==============================================================================
--- 
pdfbox/branches/3.0/examples/src/test/java/org/apache/pdfbox/examples/pdfa/MergePDFATest.java
 (original)
+++ 
pdfbox/branches/3.0/examples/src/test/java/org/apache/pdfbox/examples/pdfa/MergePDFATest.java
 Sun Apr  6 05:04:35 2025
@@ -30,7 +30,6 @@ import org.apache.pdfbox.io.RandomAccess
 import org.apache.pdfbox.preflight.ValidationResult;
 import org.apache.pdfbox.preflight.parser.PreflightParser;
 import static org.junit.jupiter.api.Assertions.assertTrue;
-import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.verapdf.core.VeraPDFException;
 import org.verapdf.gf.foundry.VeraGreenfieldFoundryProvider;
@@ -45,20 +44,20 @@ import org.verapdf.pdfa.flavours.PDFAFla
  */
 class MergePDFATest
 {
-    private final String outDir = "target/test-output";
+    private static final String OUTDIR = "target/test-output";
 
-    @BeforeEach
-    void setUp()
+    @BeforeAll
+    static void setUp()
     {
-        new File(outDir).mkdirs();
+        new File(OUTDIR).mkdirs();
     }
 
     @Test
     void testMergePDFA() throws IOException, TransformerException, 
VeraPDFException
     {
         System.out.println("testMergePDFA");
-        String pdfaFilename = outDir + "/Source_PDFA.pdf";
-        String pdfaMergedFilename = outDir + "/Merged_PDFA.pdf";
+        String pdfaFilename = OUTDIR + "/Source_PDFA.pdf";
+        String pdfaMergedFilename = OUTDIR + "/Merged_PDFA.pdf";
         String message = "The quick brown fox jumps over the lazy dog 
äöüÄÖÜß @°^²³ {[]}";
         String dir = 
"../pdfbox/src/main/resources/org/apache/pdfbox/resources/ttf/";
         String fontfile = dir + "LiberationSans-Regular.ttf";

Modified: 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAcroFormsTest.java
URL: 
http://svn.apache.org/viewvc/pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAcroFormsTest.java?rev=1924853&r1=1924852&r2=1924853&view=diff
==============================================================================
--- 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAcroFormsTest.java
 (original)
+++ 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAcroFormsTest.java
 Sun Apr  6 05:04:35 2025
@@ -32,7 +32,7 @@ import org.apache.pdfbox.multipdf.PDFMer
 import org.apache.pdfbox.pdmodel.PDDocument;
 import org.apache.pdfbox.pdmodel.interactive.form.PDAcroForm;
 import org.apache.pdfbox.pdmodel.interactive.form.PDField;
-import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.parallel.Execution;
 import org.junit.jupiter.api.parallel.ExecutionMode;
@@ -49,8 +49,8 @@ class MergeAcroFormsTest
     private static final File OUT_DIR = new File("target/test-output/merge/");
     private static final File TARGET_PDF_DIR = new File("target/pdfs");
 
-    @BeforeEach
-    void setUp()
+    @BeforeAll
+    static void setUp()
     {
         OUT_DIR.mkdirs();
     }

Modified: 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAnnotationsTest.java
URL: 
http://svn.apache.org/viewvc/pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAnnotationsTest.java?rev=1924853&r1=1924852&r2=1924853&view=diff
==============================================================================
--- 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAnnotationsTest.java
 (original)
+++ 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAnnotationsTest.java
 Sun Apr  6 05:04:35 2025
@@ -30,7 +30,7 @@ import org.apache.pdfbox.cos.COSName;
 import org.apache.pdfbox.pdmodel.PDDocument;
 import org.apache.pdfbox.pdmodel.PDDocumentNameDestinationDictionary;
 import org.apache.pdfbox.pdmodel.interactive.annotation.PDAnnotation;
-import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -41,12 +41,12 @@ class MergeAnnotationsTest
     private static final File OUT_DIR = new File("target/test-output/merge/");
     private static final File TARGET_PDF_DIR = new File("target/pdfs");
 
-    @BeforeEach
-    void setUp()
+    @BeforeAll
+    static void setUp()
     {
         OUT_DIR.mkdirs();
     }
-    
+
     /*
      * PDFBOX-1065 Ensure that after merging the PDFs there are all link
      * annotations and they point to the correct page.

Modified: 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/OverlayTest.java
URL: 
http://svn.apache.org/viewvc/pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/OverlayTest.java?rev=1924853&r1=1924852&r2=1924853&view=diff
==============================================================================
--- 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/OverlayTest.java
 (original)
+++ 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/OverlayTest.java
 Sun Apr  6 05:04:35 2025
@@ -38,7 +38,7 @@ import org.apache.pdfbox.pdmodel.font.St
 import org.apache.pdfbox.rendering.PDFRenderer;
 
 import org.junit.jupiter.api.Assertions;
-import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -49,13 +49,9 @@ class OverlayTest
 {
     private static final File IN_DIR = new 
File("src/test/resources/org/apache/pdfbox/multipdf");
     private static final File OUT_DIR = new File("target/test-output/overlay");
-    
-    OverlayTest()
-    {
-    }
 
-    @BeforeEach
-    void setUp()
+    @BeforeAll
+    static void setUp()
     {
         OUT_DIR.mkdirs();
     }

Modified: 
pdfbox/branches/3.0/xmpbox/src/test/java/org/apache/xmpbox/type/TestDerivedType.java
URL: 
http://svn.apache.org/viewvc/pdfbox/branches/3.0/xmpbox/src/test/java/org/apache/xmpbox/type/TestDerivedType.java?rev=1924853&r1=1924852&r2=1924853&view=diff
==============================================================================
--- 
pdfbox/branches/3.0/xmpbox/src/test/java/org/apache/xmpbox/type/TestDerivedType.java
 (original)
+++ 
pdfbox/branches/3.0/xmpbox/src/test/java/org/apache/xmpbox/type/TestDerivedType.java
 Sun Apr  6 05:04:35 2025
@@ -51,7 +51,7 @@ class TestDerivedType
     protected Constructor<? extends TextType> constructor = null;
 
     @BeforeEach
-    public void before() throws Exception
+    void before() throws Exception
     {
         xmp = XMPMetadata.createXMPMetadata();
     }

Reply via email to