svn commit: r1924852 - in /pdfbox/trunk: examples/src/test/java/org/apache/pdfbox/examples/pdfa/ pdfbox/src/test/java/org/apache/pdfbox/multipdf/ pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/ pdfbox/src/test/jav...

Sat, 05 Apr 2025 22:04:48 -0700 

Author: tilman
Date: Sun Apr  6 05:04:26 2025
New Revision: 1924852

URL: http://svn.apache.org/viewvc?rev=1924852&view=rev
Log:
PDFBOX-5660: Sonar fix

Modified:
    
pdfbox/trunk/examples/src/test/java/org/apache/pdfbox/examples/pdfa/MergePDFATest.java
    
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAcroFormsTest.java
    
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAnnotationsTest.java
    
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/OverlayTest.java
    
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/PDOutlineItemTest.java
    
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/PDOutlineNodeTest.java
    
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
    
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDDefaultAppearanceStringTest.java
    
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureFieldTest.java
    
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDTextFieldTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/BidiTest.java
    
pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestExtractText.java
    
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/TestDerivedType.java

Modified: 
pdfbox/trunk/examples/src/test/java/org/apache/pdfbox/examples/pdfa/MergePDFATest.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/test/java/org/apache/pdfbox/examples/pdfa/MergePDFATest.java?rev=1924852&r1=1924851&r2=1924852&view=diff
==============================================================================
--- 
pdfbox/trunk/examples/src/test/java/org/apache/pdfbox/examples/pdfa/MergePDFATest.java
 (original)
+++ 
pdfbox/trunk/examples/src/test/java/org/apache/pdfbox/examples/pdfa/MergePDFATest.java
 Sun Apr  6 05:04:26 2025
@@ -28,7 +28,7 @@ import org.apache.pdfbox.examples.pdmode
 import org.apache.pdfbox.examples.util.PDFMergerExample;
 import org.apache.pdfbox.io.RandomAccessRead;
 import org.apache.pdfbox.io.RandomAccessReadBufferedFile;
-import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.verapdf.core.VeraPDFException;
 import org.verapdf.gf.foundry.VeraGreenfieldFoundryProvider;
@@ -44,20 +44,20 @@ import org.verapdf.pdfa.results.Validati
  */
 class MergePDFATest
 {
-    private final String outDir = "target/test-output";
+    private static final String OUTDIR = "target/test-output";
 
-    @BeforeEach
-    void setUp()
+    @BeforeAll
+    static void setUp()
     {
-        new File(outDir).mkdirs();
+        new File(OUTDIR).mkdirs();
     }
 
     @Test
     void testMergePDFA() throws IOException, TransformerException, 
VeraPDFException
     {
         System.out.println("testMergePDFA");
-        String pdfaFilename = outDir + "/Source_PDFA.pdf";
-        String pdfaMergedFilename = outDir + "/Merged_PDFA.pdf";
+        String pdfaFilename = OUTDIR + "/Source_PDFA.pdf";
+        String pdfaMergedFilename = OUTDIR + "/Merged_PDFA.pdf";
         String message = "The quick brown fox jumps over the lazy dog 
äöüÄÖÜß @°^²³ {[]}";
         String dir = 
"../pdfbox/src/main/resources/org/apache/pdfbox/resources/ttf/";
         String fontfile = dir + "LiberationSans-Regular.ttf";

Modified: 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAcroFormsTest.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAcroFormsTest.java?rev=1924852&r1=1924851&r2=1924852&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAcroFormsTest.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAcroFormsTest.java
 Sun Apr  6 05:04:26 2025
@@ -32,7 +32,7 @@ import org.apache.pdfbox.multipdf.PDFMer
 import org.apache.pdfbox.pdmodel.PDDocument;
 import org.apache.pdfbox.pdmodel.interactive.form.PDAcroForm;
 import org.apache.pdfbox.pdmodel.interactive.form.PDField;
-import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.parallel.Execution;
 import org.junit.jupiter.api.parallel.ExecutionMode;
@@ -49,8 +49,8 @@ class MergeAcroFormsTest
     private static final File OUT_DIR = new File("target/test-output/merge/");
     private static final File TARGET_PDF_DIR = new File("target/pdfs");
 
-    @BeforeEach
-    public void setUp()
+    @BeforeAll
+    static void setUp()
     {
         OUT_DIR.mkdirs();
     }

Modified: 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAnnotationsTest.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAnnotationsTest.java?rev=1924852&r1=1924851&r2=1924852&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAnnotationsTest.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAnnotationsTest.java
 Sun Apr  6 05:04:26 2025
@@ -30,7 +30,7 @@ import org.apache.pdfbox.cos.COSName;
 import org.apache.pdfbox.pdmodel.PDDocument;
 import org.apache.pdfbox.pdmodel.PDDocumentNameDestinationDictionary;
 import org.apache.pdfbox.pdmodel.interactive.annotation.PDAnnotation;
-import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -41,12 +41,12 @@ class MergeAnnotationsTest
     private static final File OUT_DIR = new File("target/test-output/merge/");
     private static final File TARGET_PDF_DIR = new File("target/pdfs");
 
-    @BeforeEach
-    public void setUp()
+    @BeforeAll
+    static void setUp()
     {
         OUT_DIR.mkdirs();
     }
-    
+
     /*
      * PDFBOX-1065 Ensure that after merging the PDFs there are all link
      * annotations and they point to the correct page.

Modified: 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/OverlayTest.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/OverlayTest.java?rev=1924852&r1=1924851&r2=1924852&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/OverlayTest.java 
(original)
+++ 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/OverlayTest.java 
Sun Apr  6 05:04:26 2025
@@ -38,7 +38,7 @@ import org.apache.pdfbox.pdmodel.font.St
 import org.apache.pdfbox.rendering.PDFRenderer;
 
 import org.junit.jupiter.api.Assertions;
-import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -50,12 +50,8 @@ class OverlayTest
     private static final File IN_DIR = new 
File("src/test/resources/org/apache/pdfbox/multipdf");
     private static final File OUT_DIR = new File("target/test-output/overlay");
     
-    OverlayTest()
-    {
-    }
-
-    @BeforeEach
-    public void setUp()
+    @BeforeAll
+    static void setUp()
     {
         OUT_DIR.mkdirs();
     }

Modified: 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/PDOutlineItemTest.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/PDOutlineItemTest.java?rev=1924852&r1=1924851&r2=1924852&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/PDOutlineItemTest.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/PDOutlineItemTest.java
 Sun Apr  6 05:04:26 2025
@@ -34,7 +34,7 @@ class PDOutlineItemTest
     private PDOutlineItem newSibling;
 
     @BeforeEach
-    public void setUp()
+    void setUp()
     {
         root = new PDOutlineItem();
         first = new PDOutlineItem();

Modified: 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/PDOutlineNodeTest.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/PDOutlineNodeTest.java?rev=1924852&r1=1924851&r2=1924852&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/PDOutlineNodeTest.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/PDOutlineNodeTest.java
 Sun Apr  6 05:04:26 2025
@@ -35,7 +35,7 @@ class PDOutlineNodeTest
     private PDOutlineItem root;
 
     @BeforeEach
-    public void setUp()
+    void setUp()
     {
         root = new PDOutlineItem();
     }

Modified: 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java?rev=1924852&r1=1924851&r2=1924852&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
 Sun Apr  6 05:04:26 2025
@@ -41,7 +41,7 @@ class PDChoiceTest
     private List<String> options;
 
     @BeforeEach
-    public void setUp()
+    void setUp()
     {
         document = new PDDocument();
         acroForm = new PDAcroForm(document);

Modified: 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDDefaultAppearanceStringTest.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDDefaultAppearanceStringTest.java?rev=1924852&r1=1924851&r2=1924852&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDDefaultAppearanceStringTest.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDDefaultAppearanceStringTest.java
 Sun Apr  6 05:04:26 2025
@@ -38,7 +38,7 @@ class PDDefaultAppearanceStringTest
     private PDType1Font helvetica; 
     
     @BeforeEach
-    public void setUp()
+    void setUp()
     {
         resources = new PDResources();
         helvetica = new PDType1Font(FontName.HELVETICA);

Modified: 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureFieldTest.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureFieldTest.java?rev=1924852&r1=1924851&r2=1924852&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureFieldTest.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureFieldTest.java
 Sun Apr  6 05:04:26 2025
@@ -43,7 +43,7 @@ class PDSignatureFieldTest
     private PDAcroForm acroForm;
 
     @BeforeEach
-    public void setUp()
+    void setUp()
     {
         document = new PDDocument();
         acroForm = new PDAcroForm(document);

Modified: 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDTextFieldTest.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDTextFieldTest.java?rev=1924852&r1=1924851&r2=1924852&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDTextFieldTest.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDTextFieldTest.java
 Sun Apr  6 05:04:26 2025
@@ -35,7 +35,7 @@ class PDTextFieldTest
     private PDAcroForm acroForm;
 
     @BeforeEach
-    public void setUp()
+    void setUp()
     {
         document = new PDDocument();
         acroForm = new PDAcroForm(document);

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/BidiTest.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/BidiTest.java?rev=1924852&r1=1924851&r2=1924852&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/BidiTest.java 
(original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/BidiTest.java Sun 
Apr  6 05:04:26 2025
@@ -82,7 +82,7 @@ class BidiTest
     }
 
     @AfterEach
-    public void tearDown() throws IOException
+    void tearDown() throws IOException
     {
         document.close();
     }

Modified: 
pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestExtractText.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestExtractText.java?rev=1924852&r1=1924851&r2=1924852&view=diff
==============================================================================
--- 
pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestExtractText.java 
(original)
+++ 
pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestExtractText.java 
Sun Apr  6 05:04:26 2025
@@ -78,7 +78,7 @@ class TestExtractText
     }
 
     @AfterEach
-    public void restoreStreams()
+    void restoreStreams()
     {
         System.setOut(originalOut);
         if (printStream != null)

Modified: 
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/TestDerivedType.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/TestDerivedType.java?rev=1924852&r1=1924851&r2=1924852&view=diff
==============================================================================
--- 
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/TestDerivedType.java 
(original)
+++ 
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/TestDerivedType.java 
Sun Apr  6 05:04:26 2025
@@ -51,7 +51,7 @@ class TestDerivedType
     protected Constructor<? extends TextType> constructor = null;
 
     @BeforeEach
-    public void before() throws Exception
+    void before() throws Exception
     {
         xmp = XMPMetadata.createXMPMetadata();
     }

Reply via email to