Jackie-Jiang commented on a change in pull request #3856: Check assigned
instances for uploading new segment
URL: https://github.com/apache/incubator-pinot/pull/3856#discussion_r258686544
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/upload/SegmentValidator.java
##########
@@ -62,7 +67,7 @@ public SegmentValidator(PinotHelixResourceManager
pinotHelixResourceManager, Con
_controllerMetrics = controllerMetrics;
}
- public void validateSegment(SegmentMetadata segmentMetadata, File
tempSegmentDir) {
+ public SegmentValidatorResponse validateSegment(SegmentMetadata
segmentMetadata, File tempSegmentDir) {
Review comment:
Well done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
