Jackie-Jiang commented on a change in pull request #3856: Check assigned
instances for uploading new segment
URL: https://github.com/apache/incubator-pinot/pull/3856#discussion_r258720423
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1697,21 +1717,14 @@ private void
sendSegmentRefreshMessage(OfflineSegmentZKMetadata segmentZKMetadat
* @param segmentMetadata Meta-data for the segment, used to access
segmentName and tableName.
*/
// NOTE: method should be thread-safe
- private void addNewOfflineSegment(SegmentMetadata segmentMetadata) {
+ private void addNewOfflineSegment(SegmentMetadata segmentMetadata,
List<String> assignedInstances) {
Review comment:
This will only be called when it's a new segment. You can call
getAssignedInstancesForSegment() when assignedInstances are not provided in
addNewSegment(), but it should not be null here. I would recommend add a
Preconditions.checkNotNull() because when we call this, the segment ZK metadata
has been updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
