chenboat commented on a change in pull request #3941: Pinot server side change
to optimize LLC segment completion with direct metadata upload.
URL: https://github.com/apache/incubator-pinot/pull/3941#discussion_r266085242
##########
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ServerSegmentCompletionProtocolHandler.java
##########
@@ -50,22 +51,30 @@
private static SSLContext _sslContext;
private static Integer _controllerHttpsPort;
+ private static boolean _commitWithMetadata;
+
private final FileUploadDownloadClient _fileUploadDownloadClient;
private final ServerMetrics _serverMetrics;
- public static void init(Configuration uploaderConfig) {
+ public static void init(Configuration uploaderConfig, boolean
commitWithMetadata) {
Review comment:
Done. Put the config into IndexLoadingConfig just like splitCommit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
