chenboat commented on a change in pull request #3941: Pinot server side change
to optimize LLC segment completion with direct metadata upload.
URL: https://github.com/apache/incubator-pinot/pull/3941#discussion_r267052942
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -681,11 +690,23 @@ protected SegmentBuildDescriptor
buildSegmentInternal(boolean forCommit) {
TimeUnit.MILLISECONDS.toSeconds(waitTimeMillis));
if (forCommit) {
+ Preconditions.checkState(destDir.listFiles() != null &&
destDir.listFiles().length > 0,
+ "The index dir is empty: ", destDir);
+ File metadataFileName = new File(destDir.listFiles()[0],
V1Constants.MetadataKeys.METADATA_FILE_NAME);
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
