mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove 
memory allocation for virtual columns in consumi…
URL: https://github.com/apache/incubator-pinot/pull/4555#discussion_r317299863
 
 

 ##########
 File path: 
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/immutable/ImmutableSegmentImpl.java
 ##########
 @@ -158,16 +158,4 @@ public void destroy() {
   public List<StarTreeV2> getStarTrees() {
     return _starTreeIndexContainer != null ? 
_starTreeIndexContainer.getStarTrees() : null;
   }
-
-  @Override
-  public GenericRow getRecord(int docId, GenericRow reuse) {
-    for (FieldSpec fieldSpec : 
_segmentMetadata.getSchema().getAllFieldSpecs()) {
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to