mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove
memory allocation for virtual columns in consumi…
URL: https://github.com/apache/incubator-pinot/pull/4555#discussion_r317302567
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -611,15 +646,18 @@ private int getOrCreateDocId(Map<String, Object>
dictIdMap) {
// All metric columns should have no-dictionary index.
// All metric columns must be single value
Review comment:
The comments at the head of the method specify the limitations.
The additional limitatation that a metric must be single value is not
specified, I can move the comment from insie the method to outside of it.
I am not sure what you want me to change/improve here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
