9aman commented on code in PR #15016:
URL: https://github.com/apache/pinot/pull/15016#discussion_r1948934502
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -611,6 +665,17 @@ protected void preProcessCommitSegmentEndMetadata() {
// No-op
}
+ private void updateCommittingSegmentsList(String realtimeTableName,
+ Callable<Boolean> operation) {
+ try {
+ DEFAULT_RETRY_POLICY.attempt(operation);
+ } catch (Exception e) {
+ _controllerMetrics.addMeteredTableValue(realtimeTableName,
ControllerMeter.LLC_ZOOKEEPER_UPDATE_FAILURES, 1L);
+ LOGGER.error("Failed to update committing segments list for table: {}",
realtimeTableName, e);
+ throw new RuntimeException(e);
Review Comment:
Yes, even I felt that we should not be throwing an exception here.
```
Any inconsistencies will fixed in SegmentValidationManager right.
```
Addition of segment is a bit tricky and can only be done when segment level
validations are done.
Removal can be easily handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
