swaminathanmanish commented on code in PR #15016:
URL: https://github.com/apache/pinot/pull/15016#discussion_r1949482595
##########
pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java:
##########
@@ -186,6 +199,19 @@ private void runSegmentLevelValidation(TableConfig
tableConfig) {
}
}
+ private void addSegmentsInCommittingStatus(String realtimeTableName,
Review Comment:
Small optimization - Whereever we loop over all segmentZkMetadata, we can
insert this snippet, so that we loop only once in the ValidationManager (eg:
computeTotalDocumentCount is another place we loop over all segments)
Also can we not fix both additions/removal in the same place and prepare one
list of committing segments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
