gortiz commented on code in PR #15037:
URL: https://github.com/apache/pinot/pull/15037#discussion_r1975562169
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -726,18 +722,18 @@ protected BrokerResponse doHandleRequest(long requestId,
String query, SqlNodeAn
String realtimeRoutingPolicy = realtimeBrokerRequest != null ?
getRoutingPolicy(realtimeTableConfig) : null;
String offlineRoutingPolicy = offlineBrokerRequest != null ?
getRoutingPolicy(offlineTableConfig) : null;
errorMessage = addRoutingPolicyInErrMsg(errorMessage,
realtimeRoutingPolicy, offlineRoutingPolicy);
-
exceptions.add(QueryException.getException(QueryException.BROKER_SEGMENT_UNAVAILABLE_ERROR,
errorMessage));
+ errorMsgs.add(new
BrokerResponseErrorMessage(QueryErrorCode.BROKER_SEGMENT_UNAVAILABLE,
errorMessage));
_brokerMetrics.addMeteredTableValue(rawTableName,
BrokerMeter.BROKER_RESPONSES_WITH_UNAVAILABLE_SEGMENTS, 1);
}
if (offlineBrokerRequest == null && realtimeBrokerRequest == null) {
- if (!exceptions.isEmpty()) {
- ProcessingException firstException = exceptions.get(0);
- String logTail = exceptions.size() > 1 ? (exceptions.size()) + "
exceptions found. Logging only the first one"
+ if (!errorMsgs.isEmpty()) {
+ BrokerResponseErrorMessage firstErrorMsg = errorMsgs.get(0);
+ String logTail = errorMsgs.size() > 1 ? (errorMsgs.size()) + "
errorMsgs found. Logging only the first one"
: "1 exception found";
- LOGGER.info("No server found for request {}: {}. {}", requestId,
query, logTail, firstException);
+ LOGGER.info("No server found for request {}: {}. {}", requestId,
query, logTail, firstErrorMsg);
Review Comment:
Nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
