gortiz commented on code in PR #15037:
URL: https://github.com/apache/pinot/pull/15037#discussion_r1975625657
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseSingleBlockCombineOperator.java:
##########
@@ -112,11 +113,17 @@ protected void processSegments() {
@Override
protected void onProcessSegmentsException(Throwable t) {
_processingException.compareAndSet(null, t);
- if (t instanceof BadQueryRequestException) {
- _blockingQueue.offer(new
ExceptionResultsBlock(QueryException.QUERY_VALIDATION_ERROR, t));
+ ExceptionResultsBlock errBlock;
+ if (t instanceof QueryException) {
+ QueryException queryException = (QueryException) t;
+ QueryErrorMessage errMsg =
QueryErrorMessage.safeMsg(queryException.getErrorCode(),
queryException.getMessage());
+ errBlock = new ExceptionResultsBlock(errMsg);
Review Comment:
We are already logging in the code that calls this method. Anyway, these
logs will change in the next PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
