mayankshriv commented on a change in pull request #4602: First pass of GROUP BY
with ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r325805705
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/query/AggregationGroupByOperator.java
##########
@@ -58,6 +64,34 @@ public AggregationGroupByOperator(@Nonnull
AggregationFunctionContext[] function
_transformOperator = transformOperator;
_numTotalRawDocs = numTotalRawDocs;
_useStarTree = useStarTree;
+
+ int numColumns = groupBy.getExpressionsSize() + _functionContexts.length;
Review comment:
Seems like this is a change in the default path, purely due to signature
change for constructor of IntermediateResultBlock? Ideally, I'd want to have no
changes to default path while this project is still on-going. Of course, we can
take smart risks depending on how the change. I'll let you assess that for this
case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
