mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r332620855
########## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/Record.java ########## @@ -43,4 +46,9 @@ public Key getKey() { public Object[] getValues() { return _values; } + + @Override + public String toString() { + return _key.toString() + " " + Arrays.deepToString(_values); Review comment: Will this String be used for de-serialization? And can key have whitespaces? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org