somandal commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994442520
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java:
##########
@@ -878,9 +878,10 @@ private void checkRebalancePreCheckStatus(RebalanceResult
rebalanceResult, Rebal
assertEquals(rebalanceResult.getStatus(), expectedStatus);
Map<String, String> preChecksResult = rebalanceResult.getPreChecksResult();
assertNotNull(preChecksResult);
- assertEquals(preChecksResult.size(), 2);
+ assertEquals(preChecksResult.size(), 3);
assertTrue(preChecksResult.containsKey(DefaultRebalancePreChecker.IS_MINIMIZE_DATA_MOVEMENT));
assertTrue(preChecksResult.containsKey(DefaultRebalancePreChecker.NEEDS_RELOAD_STATUS));
+
assertTrue(preChecksResult.containsKey(DefaultRebalancePreChecker.DISK_UTILIZATION));
Review Comment:
Lines of code should never be a concern if the tests are useful. Can you
check if the value of this will even change throughout this test case if you
don't add any specific tests related to disk utilization? It would be good to
at least assert on that value. To add tests for this here, will you need to add
the fake disk util pieces you added to the other test? If not, it might still
be useful to add 1-2 test cases here. If it's the same, then no need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
