swaminathanmanish commented on code in PR #15383:
URL: https://github.com/apache/pinot/pull/15383#discussion_r2016218907
##########
pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java:
##########
@@ -126,8 +127,15 @@ protected void processTable(String tableNameWithType,
Context context) {
}
boolean isPauselessConsumptionEnabled =
PauselessConsumptionUtils.isPauselessEnabled(tableConfig);
+ boolean isPartialUpsertEnabled =
+ tableConfig.getUpsertConfig() != null &&
tableConfig.getUpsertConfig().getMode() == UpsertConfig.Mode.PARTIAL;
+ boolean isDedupEnabled = tableConfig.getDedupConfig() != null &&
tableConfig.getDedupConfig().isDedupEnabled();
+
if (isPauselessConsumptionEnabled) {
-
_llcRealtimeSegmentManager.repairSegmentsInErrorStateForPauselessConsumption(tableConfig.getTableName());
+ if (!(isPartialUpsertEnabled || isDedupEnabled)) {
Review Comment:
@KKcorps, @9aman - We want to only disable re-ingestion right? Don't we
want to still do reset for segments in error (i.e prevent triggerReingestion)
and not entire repairSegmentsInErrorStateForPauselessConsumpti.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
