Jackie-Jiang commented on code in PR #15383:
URL: https://github.com/apache/pinot/pull/15383#discussion_r2017188192
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -2425,10 +2427,22 @@ public void
repairSegmentsInErrorStateForPauselessConsumption(String realtimeTab
}
}
+ _controllerMetrics.setOrUpdateTableGauge(realtimeTableName,
+ ControllerGauge.PAUSELESS_SEGMENTS_IN_ERROR_COUNT,
segmentsInErrorStateInAllReplicas.size());
+
if (segmentsInErrorStateInAtLeastOneReplica.isEmpty()) {
return;
}
+ boolean isPartialUpsertEnabled =
Review Comment:
Probably also emit a metric for error segments not able to fix. We need to
get immediate alert on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
