somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2019841819
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##########
@@ -380,6 +464,11 @@ public RebalanceChangeInfo getNumSegmentsInSingleReplica()
{
public RebalanceChangeInfo getNumSegmentsAcrossAllReplicas() {
return _numSegmentsAcrossAllReplicas;
}
+
+ @JsonProperty
+ public ConsumingSegmentToBeMovedSummary
getConsumingSegmentToBeMovedSummary() {
Review Comment:
also AFAIK it works correctly for `RebalanceResult`:
```
@JsonInclude(JsonInclude.Include.NON_NULL)
private final Map<String, InstancePartitions> _tierInstanceAssignment;
```
I never see this show up as null in the result
Can you double check if something else is going on due to which you've had
to add this to the getter instead of the field? better to understand why it is
not working as expected and see if we can avoid adding the annotation to
getter, or if we need to add it to getter than understand why
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
