somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2019839654
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##########
@@ -34,10 +34,7 @@
@JsonIgnoreProperties(ignoreUnknown = true)
@JsonInclude(JsonInclude.Include.NON_NULL)
public class RebalanceSummaryResult {
-
- @JsonInclude(JsonInclude.Include.NON_NULL)
private final ServerInfo _serverInfo;
- @JsonInclude(JsonInclude.Include.NON_NULL)
private final SegmentInfo _segmentInfo;
Review Comment:
I see you've removed these, but I don't see them added back in any way? can
you add them back? and double check the field vs. getter stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
