somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2019840387


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##########
@@ -380,6 +464,11 @@ public RebalanceChangeInfo getNumSegmentsInSingleReplica() 
{
     public RebalanceChangeInfo getNumSegmentsAcrossAllReplicas() {
       return _numSegmentsAcrossAllReplicas;
     }
+
+    @JsonProperty
+    public ConsumingSegmentToBeMovedSummary 
getConsumingSegmentToBeMovedSummary() {

Review Comment:
   can you check the jackson version we use and see if there is any regression? 
it might be better to leave the annotations at the field level if there is some 
regression that'll get fixed with newer versions 
   cc @Jackie-Jiang 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to