somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2025722585
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -140,10 +156,20 @@ public TableRebalancer(HelixManager helixManager,
@Nullable TableRebalanceObserv
_controllerMetrics = controllerMetrics;
_rebalancePreChecker = rebalancePreChecker;
_tableSizeReader = tableSizeReader;
+ _executorService = executorService;
+ _connectionManager = connectionManager;
+ _pinotHelixResourceManager = pinotHelixResourceManager;
+ }
+
+ public TableRebalancer(HelixManager helixManager, @Nullable
TableRebalanceObserver tableRebalanceObserver,
Review Comment:
@J-HowHuang let's remove this constructor? why is this needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
