siddharthteotia commented on code in PR #15585:
URL: https://github.com/apache/pinot/pull/15585#discussion_r2054581153
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerTimer.java:
##########
@@ -30,7 +30,16 @@ public enum ControllerTimer implements AbstractMetrics.Timer
{
CRON_SCHEDULER_JOB_EXECUTION_TIME_MS("cronSchedulerJobExecutionTimeMs",
false),
IDEAL_STATE_UPDATE_TIME_MS("IdealStateUpdateTimeMs", false),
// How long it took the server to start.
- STARTUP_SUCCESS_DURATION_MS("startupSuccessDurationMs", true);
+ STARTUP_SUCCESS_DURATION_MS("startupSuccessDurationMs", true),
+ // TotalTime = segmentDeepStoreDownloadTimeMs + segmentProcessingTime
(controller local processing)
+ SEGMENT_TOTAL_DOWNLOAD_TIME_MS("segmentDownloadTotalTimeMs", true),
+ // Time taken to download the segment from deep store
+ SEGMENT_DEEP_STORE_DOWNLOAD_TIME_MS("segmentDeepStoreDownloadTimeMs", true),
+ // TotalTime = segmentUploadTimeMs + segmentProcessingTime (controller local
processing)
+ SEGMENT_TOTAL_UPLOAD_TIME_MS("segmentUploadTotalTimeMs", true),
+ // Time taken to upload the segment to remote store
Review Comment:
Comment is misleading. No need to say remote. May be just say deep store ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
