praveenc7 commented on code in PR #15585:
URL: https://github.com/apache/pinot/pull/15585#discussion_r2055094779
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java:
##########
@@ -43,8 +43,13 @@ public enum ServerTimer implements AbstractMetrics.Timer {
RESPONSE_SER_CPU_TIME_NS("nanoseconds", false, "Query cost (response
serialization cpu time) "
+ "for query processing on server. Computed as the time spent in
serializing query response on servers"),
-
- SEGMENT_UPLOAD_TIME_MS("milliseconds", false),
+ // Measures only the time taken to upload the segment to the deep store,
doesn't include server processing time
+ SEGMENT_UPLOAD_TIME_MS("milliseconds", true),
Review Comment:
Based on offline discussion with Subbu & Vivek, decided not to do
server-side metrics since the bottleneck currently is around controller direct
operations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
