somandal commented on PR #15618: URL: https://github.com/apache/pinot/pull/15618#issuecomment-2848089933
> Imagine that we set `externalViewStabilizationTimeoutInMs` super short (relative to 1hr today), say 10000ms, a regular rebalance with `bestEfforts=false` should finish as usual. However the same timeout with `bestEfforts=true` will get a lot of funny unhealthy states because one single 10000ms is not enough for EV to converge. > > In my opinion bestEfforts should only make difference when a regular run would've failed (due to timeout, or ERROR state), in the above case the regular run is fine so `bestEfforts` is not supposed to matter. But the current code will make a different behavior though. I am not against this change. I'm just recommending we have a discussion on this and tackle it as a separate PR. Will that work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
