somandal commented on PR #15618: URL: https://github.com/apache/pinot/pull/15618#issuecomment-2848044561
> @yashmayya @somandal , for `bestEfforts=true`, it stops waiting convergence once reaching the first timeout period. Should we change it to keeping waiting until converge, and continue without throwing timeout exception if no progress (so that it matches the behavior of `bestEfforts=false`, just not throwing exceptions) My understanding of bestEfforts is to go as fast as well as skip ERROR segments. Let's build consensus on this first and make a separate PR to change the behavior if it makes sense to do this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
