gortiz commented on PR #15698: URL: https://github.com/apache/pinot/pull/15698#issuecomment-2851204742
> The current QueryEnvironment I feel is quite bloated and I know several folks have also raised this. For now I have added the requestId to QueryEnvironment#Config. This eliminates passing the requestId across method calls like toDispatchableSubPlan so I think it is overall still a relatively clean approach. You don't need to do that. Instead, you can rely on `QueryThreadContext.getRequestId()`, which should be set for all threads running this code. Remember we also introduced `QueryThreadContext.getCid()`, which, contrary to `requestId`, is stable once set. I didn't remove old usages of request id because I didn't want to make refactors more complex, but if you have to do it now, it is probably better to use QueryThreadContext. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
