ankitsultana commented on PR #15698: URL: https://github.com/apache/pinot/pull/15698#issuecomment-2851433403
@gortiz : thanks for sharing. I'll raise another one after this to address this. As for the cleanup, I wanted to make a change which explicitly tracks whether the QueryEnvironment usage is in the controller or the broker. Right now I think we implicitly infer this by checking whether `envConfig.getWorkerManager()` is non-null. Lmk if that assumption is correct. Ideally I'd like to take a stab at the TODO shown below but I think it's best to do it once I mainline the physical optimizer. <img width="993" alt="image" src="https://github.com/user-attachments/assets/72f16cec-bb06-4fc0-a4cd-339062984f53"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
