vrajat commented on code in PR #15720:
URL: https://github.com/apache/pinot/pull/15720#discussion_r2080922930
##########
pinot-common/src/main/java/org/apache/pinot/common/config/provider/TableCache.java:
##########
@@ -663,6 +665,30 @@ public synchronized void handleDataDeleted(String path) {
}
}
+ private static Map<Expression, Expression>
createExpressionOverrideMap(String tableName, QueryConfig queryConfig) {
Review Comment:
`tableName` -> `physicalOrLogicalTableName`
##########
pinot-common/src/main/java/org/apache/pinot/common/config/provider/TableCache.java:
##########
@@ -232,7 +232,11 @@ public Map<String, String> getColumnNameMap(String
rawTableName) {
@Nullable
public Map<Expression, Expression> getExpressionOverrideMap(String
tableNameWithType) {
Review Comment:
This was brought up in another PR as well. `tableNameWithType` is
misleading. Rename to `physicalOrLogicalTableName` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
