abhishekbafna commented on code in PR #15720:
URL: https://github.com/apache/pinot/pull/15720#discussion_r2081293964
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##########
@@ -414,15 +414,17 @@ public synchronized void includeServerToRouting(String
instanceId) {
}
/**
- * Builds/rebuilds the routing for the given table.
+ * Builds/rebuilds the routing for the physical table, for logical tables it
is skipped.
+ * @param physicalOrLogicalTable a physical table with type or logical table
name
*/
- public synchronized void buildRouting(String tableNameWithType) {
+ public synchronized void buildRouting(String physicalOrLogicalTable) {
// skip route building for logical tables
- if (ZKMetadataProvider.isLogicalTableExists(_propertyStore,
tableNameWithType)) {
- LOGGER.info("Skipping route building for logical table: {}",
tableNameWithType);
+ if (ZKMetadataProvider.isLogicalTableExists(_propertyStore,
physicalOrLogicalTable)) {
+ LOGGER.info("Skipping route building for logical table: {}",
physicalOrLogicalTable);
return;
}
+ String tableNameWithType = physicalOrLogicalTable;
Review Comment:
Introduced a local variable to keep the remaining code unchanged and
contextual as it should be a table name with type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
