NihalJain opened a new pull request, #15861: URL: https://github.com/apache/pinot/pull/15861
…n behaviour To address #14932, this PR extracts the common authorization logic into a superclass `AbstractBasicAuthAccessControl` and makes both `BasicAuthAccessControlFactory.BasicAuthAccessControl` and `ZkBasicAuthAccessFactory.BasicAuthAccessControl` extend this superclass. This ensures that the core authorization logic for basic auth is centralized, making it easier to maintain and update. The same has been done across all components and we have extracted shared logic via appropriate utilities or classes wherever needed. Also several other refactorings have been done to align with existing code. - `pinot-controller/../AccessControlFactory.java` adds a new method `loadFactory` which is used to init in `BaseControllerStarter.java` - Extract the `getPrincipal` logic into `BasicAuthUtils.java` for each component and re-use. These refactoring will streamline maintenance, enhance consistency, and simplify the process of adding new authorization mechanisms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
